fix(#10609): remove isChromatic on real build #10613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d11cf8.
Codecov Report
@@ Coverage Diff @@
## develop #10613 +/- ##
========================================
Coverage 78.33% 78.33%
========================================
Files 164 164
Lines 20445 20446 +1
Branches 363 363
========================================
+ Hits 16016 16017 +1
Misses 4429 4429
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
（プロダクションビルドできるか確認してなかったな？） Storybookちゃんと動くか確認お願いします |
なのでビルド通ってる |
|
👍 |
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
…#10613) * perf: remove isChromatic on real build * revert: Revert misskey-dev#10475 in MkTime This reverts commit 7d11cf8. * @rollup/plugin-replace as dependencies * fix pnpm-lock,yaml --------- Co-authored-by: tamaina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
isChromatic()をプロダクションビルドで消すWhy
Fix #10609
Additional info (optional)
Checklist